Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create shard snapshot #6593

Merged
merged 1 commit into from
May 11, 2016
Merged

create shard snapshot #6593

merged 1 commit into from
May 11, 2016

Conversation

corylanou
Copy link
Contributor

@corylanou corylanou commented May 10, 2016 •
edited
Loading

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @e-dard, @mark-rushakoff and @aviau to be potential reviewers

jwilder
jwilder reviewed May 10, 2016
View reviewed changes
tsdb/engine/tsm1/file_store.go
// currentTempDirID is used to create unique directories for snapshotting
// This is ephemeral, and resets every time the service restarts
// All old tmp directories are deleted on startup, so we ensure no collisions
var currentTempDirID int
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this onto FileStore? FileStore manages the shard TSM file paths and it's a little odd to have a package variable protected by an instance of FileStore. There is only ever 1 FileStore for a shard at any given time.

Also, we shouldn't rely on the dir always getting deleted (which could fail). So it should scan the dir when opening to find the max ID similar to how we load shards.

@corylanou corylanou force-pushed the cjl-copyshard branch 4 times, most recently from 2cfc786 to ddc26e5 Compare May 10, 2016 15:57
@corylanou corylanou changed the title wip - create shard snapshot create shard snapshot May 10, 2016
@jwilder
Copy link
Contributor

jwilder commented May 10, 2016

👍

@jwilder jwilder added this to the 1.0.0 milestone May 10, 2016
@corylanou corylanou merged commit c32906a into master May 11, 2016
@corylanou corylanou deleted the cjl-copyshard branch May 11, 2016 01:02
timhallinflux added a commit that referenced this pull request Dec 20, 2016
@timhallinflux
Update CHANGELOG.md
3d819ab 
Features reported in v0.13.0:
- [#6593](#6593): Add ability to create snapshots of shards.
- [#6585](#6585): Parallelize iterators

were not released until v1.0.0.  Moved these into the v1.0.0 release notes.
@timhallinflux timhallinflux modified the milestones: 1.0.0 beta, 1.0.0 Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@corylanou @mention-bot @jwilder @timhallinflux